Review: Approve Diff looks good. There was one place in src/indicator-sound.c that caught my eye - but it was not related to this diff. The "value-change" signal connected on line 283 - is there possibility of that firing after newitem has been freed? This would cause a segfault in value_changed_event_cb. I could not tell that just from looking at the code... Maybe it's not a problem. -- https://code.launchpad.net/~cjcurran/indicator-sound/thematic_changes_handling_for_blocking/+merge/24160 Your team ayatana-commits is subscribed to branch lp:indicator-sound.
_______________________________________________ Mailing list: https://launchpad.net/~ayatana-commits Post to : [email protected] Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
