Review: Approve
Looks better to me. In the 2 widgets, the _dispose function leaks memory. While 
I appreciate that it's tedious to maintain that during the UI prototyping 
phase, at least it'd deserve a big /* TODO */ in those functions to make it 
obvious there is a huge leak. Otherwise, cool!

+1 with the /* TODO */ lines added.
-- 
https://code.launchpad.net/~cjcurran/indicator-sound/custom_player_controls/+merge/27612
Your team ayatana-commits is subscribed to branch lp:indicator-sound.

_______________________________________________
Mailing list: https://launchpad.net/~ayatana-commits
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~ayatana-commits
More help   : https://help.launchpad.net/ListHelp

Reply via email to