Review: Needs Fixing
- Can use result.has_prefix ("file://") instead of .contains
- metadata_widget_property_update should have a g_return_if_fail
(METADATA_IS_WIDGET (userdata)) to protect from bad pointers
- g_strdup(g_value_get_string(value) can be g_value_dup_string (value)
- Should be freeing the old priv->image_path string before setting it to a new
one?
- gtk_button_set_label(GTK_BUTTON(priv->play_button),
g_strdup(transport_widget_toggle_play_label(property))); looks like a leak,
gtk_button_set_label takes a const gchar *, and should dup it itself.
--
https://code.launchpad.net/~cjcurran/indicator-sound/mpris-backend/+merge/27847
Your team ayatana-commits is subscribed to branch lp:indicator-sound.
_______________________________________________
Mailing list: https://launchpad.net/~ayatana-commits
Post to : [email protected]
Unsubscribe : https://launchpad.net/~ayatana-commits
More help : https://help.launchpad.net/ListHelp
