Review: Needs Information Hmm, I'm not sure exactly how that fixes icon switching.
1. The code is definitely clearer: good ;) Now for nitpicking: 2. If there is a bug to fix, is there a bug report? If there is an error, is there a test case to show that this fixes the error? 3. is the second g_return_if_fail checking for a legitimate development error (http://library.gnome.org/devel/glib/stable/glib-Warnings-and-Assertions.html#glib-Warnings-and-Assertions.description) or shouldn't be an if (..) return? -- https://code.launchpad.net/~ted/indicator-application/icon-switching/+merge/27901 Your team ayatana-commits is subscribed to branch lp:indicator-application. _______________________________________________ Mailing list: https://launchpad.net/~ayatana-commits Post to : [email protected] Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
