Review: Needs Fixing Line 125: a bit uneasy to see priv dereferenced without being controlled first; is the GET_PRIVATE macro ensuring you will return immediately if passed some garbage/null pointer? Being a callback, it makes sense to be a bit picky.
Otherwise, good for me. -- https://code.launchpad.net/~ted/dbusmenu/show-menu-on-activate/+merge/33268 Your team ayatana-commits is subscribed to branch lp:dbusmenu. _______________________________________________ Mailing list: https://launchpad.net/~ayatana-commits Post to : [email protected] Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
