Conor Curran has proposed merging
lp:~cjcurran/indicator-sound/metadata-widget-blank-maverick into
lp:indicator-sound/sound-menu-v2.
Requested reviews:
Indicator Applet Developers (indicator-applet-developers)
Fixes slight visual bug whereby on starting media client (like rhythmbox )the
metadata widget (the part of the menu which holds the track album art and text)
does not appear unless the widget is populated.
--
https://code.launchpad.net/~cjcurran/indicator-sound/metadata-widget-blank-maverick/+merge/40621
Your team ayatana-commits is subscribed to branch
lp:indicator-sound/sound-menu-v2.
=== modified file 'src/player-item.vala'
--- src/player-item.vala 2010-09-03 19:05:42 +0000
+++ src/player-item.vala 2010-11-11 13:01:32 +0000
@@ -87,9 +87,7 @@
this.property_set_bool(property, v.get_boolean());
}
}
- if(this.property_get_bool(MENUITEM_PROP_VISIBLE) == false){
- this.property_set_bool(MENUITEM_PROP_VISIBLE, true);
- }
+ this.property_set_bool(MENUITEM_PROP_VISIBLE, populated(attributes));
}
public bool populated(HashSet<string> attrs)
@@ -97,8 +95,8 @@
foreach(string prop in attrs){
debug("populated ? - prop: %s", prop);
int value_int = property_get_int(prop);
- debug("populated ? - prop %s and value %i", prop, value_int);
if(property_get_int(prop) != EMPTY){
+ debug("populated ? - prop %s and value %i", prop, value_int);
return true;
}
}
_______________________________________________
Mailing list: https://launchpad.net/~ayatana-commits
Post to : [email protected]
Unsubscribe : https://launchpad.net/~ayatana-commits
More help : https://help.launchpad.net/ListHelp
