I agree with the points, but I'm going to table them to "future work" so that we can get this merged and stop blocking people. I don't believe that any of them are blockers.
To answer a couple of questions, yeah the GMarkup XML parse isn't very robust and so that's why I needed the XSLT. Most GNOME projects are using an XSLT script to turn the DBus API into docbook. Not sure that's better really :-/ I used the heap allocated Builders and Iters because well, I didn't understand them as well when I started. I've tried to refactor most of them to be stack allocated. I also want to start using them instead of arrays to collect things like IDs that are going to be turned into Variants in the end anyway. Lots of possibilities for improvement there. -- https://code.launchpad.net/~ted/dbusmenu/kill-dbus-glib/+merge/42543 Your team ayatana-commits is subscribed to branch lp:dbusmenu. _______________________________________________ Mailing list: https://launchpad.net/~ayatana-commits Post to : [email protected] Unsubscribe : https://launchpad.net/~ayatana-commits More help : https://help.launchpad.net/ListHelp
