Review: Needs Fixing
On Tue, 2011-02-15 at 00:59 +0000, Luke Yelavich wrote:
> @@ -205,10 +230,14 @@
>
> if (prop) {
> indicator_image_helper_update(GTK_IMAGE(main_image),
> "indicator-messages-new");
> + accessible_desc = g_strdup(_("New Messages"));
> } else {
> indicator_image_helper_update(GTK_IMAGE(main_image),
> "indicator-messages");
> + accessible_desc = g_strdup(_("Messages"));
> }
>
> + update_a11y_desc();
> +
> return;
> }
I don't see where the accessible_desc gets free'd. In fact, I don't
think you need to do the strdup at all here as only a constant string is
required and that's what _() returns.
review needsfixing
--
https://code.launchpad.net/~themuso/indicator-messages/accessible-desc/+merge/49745
Your team ayatana-commits is subscribed to branch lp:indicator-messages.
_______________________________________________
Mailing list: https://launchpad.net/~ayatana-commits
Post to : [email protected]
Unsubscribe : https://launchpad.net/~ayatana-commits
More help : https://help.launchpad.net/ListHelp
