On Fri, Feb 10, 2012 at 10:32:00PM +0800, Marek Lindner wrote: > On Friday, February 10, 2012 07:41:40 Antonio Quartulli wrote: > > @@ -23,6 +23,8 @@ > > export CONFIG_BATMAN_ADV_DEBUG=n > > # B.A.T.M.A.N. bridge loop avoidance: > > export CONFIG_BATMAN_ADV_BLA=y > > +# B.A.T.M.A.N. distributed ARP table: > > +export CONFIG_BATMAN_ADV_DAT=n > > Any particular reason why you wish to disable it by default ?
It's a new (read experimental) feature. I don't want people that just upgrade their batman-adv package to get this new code without having been asked :-) This is the only reason for being off by default. But if you think we should push people to test it....then ok :) I can switch it to true! > > --- a/hard-interface.c > > +++ b/hard-interface.c > > @@ -119,9 +119,11 @@ static void primary_if_update_addr(struct bat_priv > > *bat_priv, if (!primary_if) > > goto out; > > > > +#ifdef CONFIG_BATMAN_ADV_DAT > > bat_priv->dht_hash = (dat_addr_t) > > choose_orig(primary_if->net_dev->dev_addr, > > DAT_ADDR_MAX); > > +#endif > > A general dat_init()/dat_free() structure would be better than adding defines > everywhere. ok, so that we can limit defines to dat.c/h and to structure definitions. nice suggestion :-) > The README update is missing in this patch. Good point. Thank you! Cheers, -- Antonio Quartulli ..each of us alone is worth nothing.. Ernesto "Che" Guevara
pgpWgALM0vvkG.pgp
Description: PGP signature
