Re: [B.A.T.M.A.N.] [PATCHv3] batman-adv: Add wrapper to look up neighbor and send skb

[Marek Lindner]

On Monday, July 09, 2012 00:00:29 Martin Hundebøll wrote:
> +bool batadv_send_skb_to_orig(struct batadv_orig_node *orig_node,
> +                            struct sk_buff *skb,
> +                            struct batadv_hard_iface *recv_if)
> +{
> +       struct batadv_priv *bat_priv = orig_node->bat_priv;
> +       struct batadv_neigh_node *neigh_node;
> +
> +       /* batadv_find_router() increases neigh_nodes refcount if found. */
> +       neigh_node = batadv_find_router(bat_priv, orig_node, recv_if);
> +       if (!neigh_node)
> +               return false;
> +
> +       /* route it */
> +       batadv_send_skb_packet(skb, neigh_node->if_incoming,
> neigh_node->addr); +
> +       batadv_neigh_node_free_ref(neigh_node);
> +
> +       return true;
> +}

Can we make the skb variable the first argument ? Something like this:

bool batadv_send_skb_to_orig(struct sk_buff *skb,
                             struct batadv_orig_node *orig_node,
                             struct batadv_hard_iface *recv_if)

Regards,
Marek