Re: [B.A.T.M.A.N.] [PATCH] alfred: in recv_alfred_packet() add break at the end of the case block

[Simon Wunderlich]

On Tue, Feb 19, 2013 at 03:36:46PM +0100, Antonio Quartulli wrote:
> In recv_alfred_packet() a "break" statement is missing at the end of a case
> block and the function is returning -1 instead of 0 even if the packet type 
> was
> known. Add a break to let the function behave correctly.
> 
> However this bug is harmless at the moment because the return value of the
> function is not checked anywhere.
> 
> Signed-off: Antonio Quartulli <anto...@open-mesh.com>
> ---
>  recv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/recv.c b/recv.c
> index 0170695..ffabba5 100644
> --- a/recv.c
> +++ b/recv.c
> @@ -416,6 +416,7 @@ int recv_alfred_packet(struct globals *globals)
>       case ALFRED_STATUS_TXEND:
>               process_alfred_status_txend(globals, &source.sin6_addr,
>                                           (struct alfred_status_v0 *)packet);
> +             break;

Applied (git rev 274133d)

Thanks,
        Simon

signature.asc
Description: Digital signature