On Fri, May 24, 2013 at 11:00:50AM +0200, Linus Lüssing wrote: > On Fri, May 24, 2013 at 10:02:25AM +0200, Linus Lüssing wrote: > > This is the second revision of the basic multicast optimization patches. > > It includes one functional fix and many style fixes, thanks to Antonios > > feedback. > > > > Three things were not included from these suggestions: > > > > * The default mcast TVLV flags were left as it is not as easy to > > switch. (see answer/explanation to [PATCH 2/3]) > > * for_each_pmc_rcu() was not moved to a commen net header file, > > only a TODO was added. Will do that after this code might have > > landed in net. > * VLAN support was not added yet as this will be some more work. Any > vlan frames with a multicast destination will still get flooded > for now so at least these patches shouldn't introduce any > regressions for those. However I have to admit that I didn't think > of VLANs yet and Marek suggested to check how much extra work it > might create later compared to adding that right from the start. > I'll have a look at that.
I think (but I am not sure) that the TT-VLAN feature that I just sent to the ml
(I have to send v3..) could probably help in this direction, because a TT entry
is not defined by its MAC address only anymore, but by the couple {MAC, vid}.
Since your code uses the TT to store the multicast addresses, I think that VLAN
support can be added "easily"[tm] after the TT-VLAN code will be in.
Cheers,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
signature.asc
Description: Digital signature
