On Fri, Sep 11, 2015 at 05:43:48PM +0200, Simon Wunderlich wrote:
> 
> On Friday 11 September 2015 17:19:56 Petr Å tetiar wrote:
> > Hi,
> > 
> > Simon Wunderlich <[email protected]> [2015-09-11 16:12:03]:
> > > @@ -1669,11 +1685,15 @@ int batadv_bla_claim_table_seq_print_text(struct
> > > seq_file *seq, void *offset)> 
> > >           hlist_for_each_entry_rcu(claim, head, hash_entry) {
> > >           
> > >                   is_own = batadv_compare_eth(claim->backbone_gw->orig,
> > >                   
> > >                                               primary_addr);
> > > 
> > > +
> > > +                 spin_lock_bh(&claim->backbone_gw->crc_lock);
> > > +                 backbone_crc = claim->backbone_gw->crc;
> > > +                 spin_lock_bh(&claim->backbone_gw->crc_lock);
> > 
> > shouldn't this be spin_unlock_bh?
> 
> Oh my, good catch! Yes, that's right!! I'll send a revised version!

Hi Simon

make C=2 is a good way to catch these. 

     Andrew

Reply via email to