On Mon, Feb 01, 2016 at 09:44:39AM +0800, Marek Lindner wrote: > On Monday, February 01, 2016 08:48:26 Antonio Quartulli wrote: > > On Mon, Feb 01, 2016 at 12:21:20AM +0800, Marek Lindner wrote: > > > The default throughput value represents Mbps and not kbps. > > > > Isn't this a bit confusing? The default throughput is expressed in multiples > > of 100kbps, not Mbps. > > Prior to my patch the debug message said: > "[..] therefore defaulting to hardcoded throughput values of 1 kbit/s." > > With the patch it says: > "[..] therefore defaulting to hardcoded throughput values of 1.0 Mbps." > > FYI, I changed the text to "Mbps" because that is what batman-adv prints in > the neighbor table as well in the originator table.
The patch is fixing the way you interpret the BATADV_THROUGHPUT_DEFAULT_VALUE constant, therefore I expected that with "The default throughput value represents Mbps" you were stating how to properly interpret such constant (and this wouldn't be correct). Cheers, -- Antonio Quartulli
signature.asc
Description: Digital signature
