Hello Sven,
Sven Eckelmann <[email protected]> schrieb am 26.02.2016 17:00:49: > Von: Sven Eckelmann <[email protected]> > An: [email protected] > Kopie: Andreas Pape <[email protected]>, Marek Lindner > <[email protected]> > Datum: 26.02.2016 17:00 > Betreff: Re: [B.A.T.M.A.N.] [PATCHv2 2/7] batman-adv: speed up dat > by snooping received ip traffic > > On Friday 26 February 2016 14:18:17 Andreas Pape wrote: > > Speeding up dat address lookup is achieved by snooping all incoming ip > > traffic. This especially increases the propability in bla setups that > > a gateway into a common backbone network already has a fitting dat entry > > to answer incoming ARP requests directly coming from the backbone > > network thus further reducing ARP traffic in the mesh. > > > > Signed-off-by: Andreas Pape <[email protected]> > > --- > [...] > > switch (ntohs(ethhdr->h_proto)) { > > + case ETH_P_IP: > > + iphdr = (struct iphdr *)(skb->data + ETH_HLEN); > > + /* snoop incoming traffic for dat update using the source mac > > + * and source ip to speed up dat. > > + */ > > + batadv_dat_entry_check(bat_priv, iphdr->saddr, > > + ethhdr->h_source, vid); > > + break; > > case ETH_P_8021Q: > > vhdr = (struct vlan_ethhdr *)skb->data; > > > > - if (vhdr->h_vlan_encapsulated_proto != ethertype) > > + if (vhdr->h_vlan_encapsulated_proto != ethertype) { > > + /* snoop incoming traffic for dat update also for vlan > > + * tagged frames. > > + */ > > + if (vhdr->h_vlan_encapsulated_proto == ETH_P_IP) { > > + iphdr = (struct iphdr *)(vhdr + > > + sizeof(struct vlan_ethhdr)); > > + batadv_dat_entry_check(bat_priv, iphdr->saddr, > > + vhdr->h_source, vid); > > + } > > Where is the code to check that there is enough data for the iphdr > (pskb_may_pull)? Same question goes to Marek for his initial change in > 48628bb9419f ("batman-adv: softif bridge loop avoidance") that introduced the > vhdr->vlan_ethhdr check > I will leave this to the result of the discussion in [1] which you started and will not handle this in the next version of my patchset. Correct? Kind regards, Andreas [1] https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2016-February/014506.html .................................................................. PHOENIX CONTACT ELECTRONICS GmbH Sitz der Gesellschaft / registered office of the company: 31812 Bad Pyrmont USt-Id-Nr.: DE811742156 Amtsgericht Hannover HRB 100528 / district court Hannover HRB 100528 Geschäftsführer / Executive Board: Roland Bent, Dr. Martin Heubeck ___________________________________________________________________ Diese E-Mail enthält vertrauliche und/oder rechtlich geschützte Informationen. Wenn Sie nicht der richtige Adressat sind oder diese E-Mail irrtümlich erhalten haben, informieren Sie bitte sofort den Absender und vernichten Sie diese Mail. Das unerlaubte Kopieren, jegliche anderweitige Verwendung sowie die unbefugte Weitergabe dieser Mail ist nicht gestattet. ---------------------------------------------------------------------------------------------------- This e-mail may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorized copying, disclosure, distribution or other use of the material or parts thereof is strictly forbidden. ___________________________________________________________________
