On Saturday, 8 July 2023 23:51:10 CEST Linus Lüssing wrote: [...] > Changelog v5: > * removed patches 1/5 + 2/5, as they were already applied > * rebased to current main branch > * changed padding behaviour: > * now 2 bytes padding on the end of the multicast > tracker TVLV, if number of destination nodes is > even > * as number of destination nodes might change between > initial check until after pushing them, functions > to post-adjust padding after pushing were added > * added/fixed TTL handling > * removed skb_pull() bailing from sub-functions of > batadv_mcast_forw_push(), to only have a single > skb_pull() to keep track of in batadv_mcast_forw_push() > to revert the changes to the skb; instead a > "unsigned short *tvlv_len" is passsed along in > batadv_mcast_.*push.*() functions to keep track of > how many bytes were pushed > * moved + verified skb->ip_summed invalidation > * batadv_mcast_forw_shrink_tracker() xmas tree ordering > * reword batadv_mcast_forw_push_dest() "Return:" kerneldoc > * fixed spelling: outter -> outer
Didn't perform any actual review. But here are the buildbot complaints. The
compiler.h is missing since patch 2 (for the "likely()").
Output of different failed tests
================================
ecsv/multicast: headers
-----------------------
diff --git a/net/batman-adv/multicast_forw.c
b/net/batman-adv/multicast_forw.c
index a90e9057..96ec3f06 100644
--- a/net/batman-adv/multicast_forw.c
+++ b/net/batman-adv/multicast_forw.c
@@ -10,6 +10,7 @@
#include <linux/bug.h>
#include <linux/build_bug.h>
#include <linux/byteorder/generic.h>
+#include <linux/compiler.h>
#include <linux/errno.h>
#include <linux/etherdevice.h>
#include <linux/gfp.h>
ecsv/multicast: kerneldoc ./net/batman-adv/multicast_forw.c
-----------------------------------------------------------
./net/batman-adv/multicast_forw.c:433: warning: Function parameter or
member 'num_dests_pushed' not described in
'batadv_mcast_forw_push_adjust_padding'
ecsv/multicast: sparse linux-5.1 cfg: BLA=y DAT=n DEBUG=n TRACING=y NC=y
MCAST=y BATMAN_V=y
---------------------------------------------------------------------------
/home/build_test/build_env/tmp.SpMnhX4MAz/net/batman-adv/multicast_forw.c:783:7:
warning: symbol 'batadv_mcast_forw_shrink_align_offset' was not declared.
Should it be static?
ecsv/multicast: unused_symbols linux-5.1 cfg: BLA=y DAT=n DEBUG=n TRACING=y
NC=y MCAST=y BATMAN_V=y
---------------------------------------------------------------------------
batadv_mcast_forw_shrink_align_offset
Kind regards,
Sven
signature.asc
Description: This is a digitally signed message part.
