I was contacted by Yuan Tan regarding some of the problems which were found by them. I've proposed to go through the list and prepare changes for things which looked sensible. I've also prepared some PoC patches (lets call it part2) - just so Antonio+Simon+Marek can discuss about them internally.
The ones which don't need further discussion are shown in this patchset. For the others, I am waiting on the results of the internal discussion. It is more than likely that there will be updates to these patches because the team around Yuan Tan need to verify that these are actually working. Thanks to Yuan Tan, Yifan Wu, Juefei Pu, Xin Liu and all the other people involved in finding + fixing these bugs. Signed-off-by: Sven Eckelmann <[email protected]> --- Changes in v3: - drop applied patches 1-3 - add patch to return errors in batadv_tvlv_container_ogm_append() - add patch to avoid reallocating the ogm buffer for each send ogm (this is actually a feature and should not be added for net.git) - Link to v2: https://patch.msgid.link/[email protected] Changes in v2: - add role checks in all tp_meter functions - free skb in batadv_v_ogm_queue_on_if - propagate bat_priv from batadv_v_ogm_queue_on_if to batadv_v_ogm_send_to_if - Link to v1: https://patch.msgid.link/[email protected] --- Sven Eckelmann (4): batman-adv: v: stop OGMv2 on disabled interface batman-adv: tvlv: reject oversized TVLV packets batman-adv: tvlv: abort OGM send on tvlv append failure batman-adv: tvlv: avoid unnecessary OGM buffer reallocations net/batman-adv/bat_iv_ogm.c | 42 ++++++++++++---------- net/batman-adv/bat_v_ogm.c | 73 +++++++++++++++++++++----------------- net/batman-adv/tvlv.c | 86 ++++++++++++++++++++++++++++----------------- net/batman-adv/tvlv.h | 5 ++- net/batman-adv/types.h | 31 ++++++++++------ 5 files changed, 142 insertions(+), 95 deletions(-) --- base-commit: b4e35f8c63511e180ea46381ec770f44bc47257b change-id: 20260509-yuantan098-bugfixes-feb66522feb6 Best regards, -- Sven Eckelmann <[email protected]>
