Hi Johannes,
Johannes Berg schrieb:
> On Mon, 2012-07-23 at 21:33 +0200, Thomas Huehn wrote:
>
>> --- a/net/mac80211/ieee80211_i.h
>> +++ b/net/mac80211/ieee80211_i.h
>> @@ -196,6 +196,8 @@ struct ieee80211_tx_data {
>> struct ieee80211_channel *channel;
>>
>> unsigned int flags;
>> +
>> + struct ieee80211_tx_control control;
>
> Why is this needed/useful?
I used it just in tx.c to pass the control pointer as function
parameter, but as I like your suggestion below it is gone in v5.
>
>> info->control.vif = vif;
>> - info->control.sta = sta;
>> + control->sta = sta;
>>
>> __skb_unlink(skb, skbs);
>> - drv_tx(local, skb);
>> + drv_tx(local, control, skb);
>
> You're assigning to it right before, and I don't see you using it any
> time before, so why not just have the control struct on the stack of
> this function?
Good idea, v5 is coming.
Greetings Thomas
_______________________________________________
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
