2012/8/9 Dan Carpenter <dan.carpen...@oracle.com>:
> On Thu, Aug 09, 2012 at 05:15:39PM +0300, Dan Carpenter wrote:
>> Hello Rafał Miłecki,
>>
>> This is a semi-automatic email about new static checker warnings.
>>
>> The patch c071b9f666be: "b43: N-PHY: add overriding RF control for
>> rev7+" from Jul 26, 2012, leads to the following Smatch complaint:
>>
>> drivers/net/wireless/b43/phy_n.c:158 b43_nphy_rf_control_override_rev7()
>> warn: variable dereferenced before check 'e' (see line 154)
>>
>> drivers/net/wireless/b43/phy_n.c
>> 153
>> 154 val_addr = (i == 0) ? e->val_addr_core0 :
>> e->val_addr_core1;
>>
>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> New dereferences.
>>
>> 155
>> 156 if (off) {
>> 157 b43_phy_mask(dev, en_addr, ~en_mask);
>> 158 if (e) /* Do it safer, better than wl
>> */
>> ^^^
>> New check.
>>
>> 159 b43_phy_mask(dev, val_addr,
>> ~e->val_mask);
>> 160 } else {
>>
>
> There is a second NULL check a couple lines down as well.
I failed at that, thanks!
--
Rafał
_______________________________________________
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
