Revised Patch attached which may better suit the principle of least surprise.
Dom Sent from OS X. If you wish to communicate more securely my PGP Public Key is 0x872524db9d74326c. On 01/02/2015 10:03, Gabriel Kerneis wrote: > On 1 February 2015 10:25:21 CET, Dave Taht <[email protected]> wrote: >> Bikeshed. >> On Jan 31, 2015 10:40 PM, "Gabriel Kerneis" <[email protected]> >> wrote: >> >>> On 1 February 2015 02:28:53 CET, Dominyk Tiller >> <[email protected]> >>> wrote: >>>> Please find a diff attached. >>> It's important that MANDIR be defined in terms of PREFIX because I >> don't >>> want to install to /usr/local if I redefined prefix to ~/bin for >> instance. >>> Looks good otherwise, mandir is the standard name indeed. >>> -- >>> Gabriel >>> >>> _______________________________________________ >>> Babel-users mailing list >>> [email protected] >>> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/babel-users >>> > > It would break a packaging script relying on PREFIX on next release. And > change existing behaviour. And violate every assumption about what PREFIX > does. > > More than bikesheding to me... >
From aa1847c154d65aa324636028ed2a85417c133cd1 Mon Sep 17 00:00:00 2001 From: Dominyk Tiller <[email protected]> Date: Sun, 1 Feb 2015 01:18:53 +0000 Subject: [PATCH] patch --- Makefile | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 7ad8b78..5702164 100644 --- a/Makefile +++ b/Makefile @@ -1,4 +1,5 @@ PREFIX = /usr/local +MANDIR = $(PREFIX)/share/man CDEBUGFLAGS = -Os -g -Wall @@ -38,12 +39,12 @@ install.minimal: babeld cp -f babeld $(TARGET)$(PREFIX)/bin install: install.minimal all - mkdir -p $(TARGET)$(PREFIX)/man/man8 - cp -f babeld.man $(TARGET)$(PREFIX)/man/man8/babeld.8 + mkdir -p $(TARGET)$(MANDIR)/man8 + cp -f babeld.man $(TARGET)$(MANDIR)/man8/babeld.8 uninstall: -rm -f $(TARGET)$(PREFIX)/bin/babeld - -rm -f $(TARGET)$(PREFIX)/man/man8/babeld.8 + -rm -f $(TARGET)$(MANDIR)/man8/babeld.8 clean: -rm -f babeld babeld.html *.o *~ core TAGS gmon.out
_______________________________________________ Babel-users mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/babel-users
