On Fri, 2013-07-19 at 15:13 -0700, Luis R. Rodriguez wrote: > From: Johannes Berg <[email protected]> > > Since kernel version 3.3, workqueue names could be > sprintf'ed instead of just pointing to a name. This > wasn't used a lot so never needed to be backported, > but now it's used everywhere. Backport this API. > > Signed-off-by: Johannes Berg <[email protected]> > [mcgrof: add WQ_HIGHPRI and WQ_MEM_RECLAIM defines]
Were they needed somehow? Thye shouldn't have been, since users of this don't usually use the flags directly? If they _are_ needed, then we probably need to do something different? My patch only backported "regular" and "ordered" workqueue, not the other flags, and I suspect the other flags can't actually be backported. > +#if LINUX_VERSION_CODE <= KERNEL_VERSION(2,6,36) > +#define WQ_HIGHPRI 0 > +#define WQ_MEM_RECLAIM 0 > #endif Ah, here. I think that would cause problems? > +static DEFINE_SPINLOCK(wq_name_lock); > +static struct list_head wq_name_list; FWIW, my patch was [RFC] for a reason, I hadn't tested it... Now that I did, I can tell you that this must be static LIST_HEAD(wq_name_list); to get the list properly initialised. johannes -- To unsubscribe from this list: send the line "unsubscribe backports" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
