Hi all:
I have the following in my host specific .pl config file:
# append /var/www directories to the standard rsync
push(@{$Conf{RsyncShareName}}, (
'/home/wcoie/bak',
'/home/otdd/bak',
'/home/toa/bak',
'/home/bbrob/bak',
'/home/rou*',
));
At some point I would like to be able to do:
/home/*/bak
to back up all directories following a pattern as as share.
However backppc is escaping the wildcards
Running: /usr/bin/ssh -q -x -l backup -o ServerAliveInterval=30
host.renesys.com sudo /usr/bin/rsync --server --sender --numeric-ids
--perms --owner --group -D --links --hard-links --times
--block-size=2048 --recursive --one-file-system --checksum-seed=32761
--ignore-times . /home/rou\\\*/
Would it make sense to have a $Conf{DonotEscapeWildcards} = 0/1
option? (An aside for the pedantic, I realize the above won't work as
intended I need to run sudo sh -c '/usr/bin/rsync.../home/rou*/' to
have the shell expansion done by root, but let's play along.)
This way you could have a mix of hosts with root maintained config
files (allowing the use of wildcards) and user maintained config file
(via the web interface) that would not allow wildcards.
Alternatively does it make sense to have separate escaping rules for
just the file paths excluding command terminators/quoting chars
'`;&|"\ but allowing the wildcard chars ?*.
This will require a change in the code to separate escaping the
command line and execing the code, but I think it would be useful.
Also the use of ' in command lines is escaped as well IIRC. However it
is useful in some instances (like my aside above). Since a comment is
made in the documentation that the actual commands should not be made
editable to normal users, does it even make sense to escape the
command line portion ($Conf{RsyncClientCmd}) of the executed command?
--
-- rouilj
John Rouillard
System Administrator
Renesys Corporation
603-643-9300 x 111
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
BackupPC-devel mailing list
BackupPC-devel@lists.sourceforge.net
List: https://lists.sourceforge.net/lists/listinfo/backuppc-devel
Wiki: http://backuppc.wiki.sourceforge.net
Project: http://backuppc.sourceforge.net/
