Hi,
Adam Goryachev wrote on 2016-10-04 09:16:47 +1100 [Re: [BackupPC-users] Error
Rsync Unexpected empty share name skipped]:
> On 04/10/16 02:36, Orazio Di nino wrote:
> > [...]
> >I have this error in the log /var/lib/backuppc/pc/192.168.2.80/LOG102016:
> >
> >-full backup started for directory /tecno
> >-unexpected empty share name skipped
> >-Backup aborted
well, have you got an empty share name in your configuration? Hint: a share
named '' (the empty string) does not make any sense. Further hint: BackupPC
says you do, so you probably do. If it's not clear, you want to look at the
value of $Conf {RsyncShareName} ...
I believe you've actually found a bug in BackupPC_dump, though. Apparently,
an empty (or duplicate) share name generates a warning only, unless it is
the last share for the host, in which case it causes the backup to fail.
That does not make sense. It should either always be a fatal error or never.
Patch attached (one of these days, I'll have a look at git ...).
> > [...]
> >Negotiated protocol version 28
> >Xfer PIDs are now 16298,16299
> >[ saltate 47 righe ]
> >Done: 37 files, 85325611 bytes
> > [...]
> >
> I think the first thing to do is get rsync to talk in US English, I
> don't think backuppc will understand any other language.
Actually, the line quoted above would seem to be generated by
BackupPC::CGI::View ;-), but I agree that quoting foreign language
diagnostic messages tends to be confusing. While for tar/smb xfer
language is important (because the diagnostic output is parsed),
I believe for rsync(d), that is not the case (but I might be
mistaken).
Regards,
Holger
--- BackupPC_dump.3.3.1.orig 2016-10-07 02:23:12.851095343 +0200
+++ BackupPC_dump.new 2016-10-07 02:29:52.579125102 +0200
@@ -631,8 +631,6 @@
# Convert $shareName to utf8 octets
#
$shareName = encode("utf8", $shareName);
- $stat{xferOK} = $stat{hostAbort} = undef;
- $stat{hostError} = $stat{lastOutputLine} = undef;
if ( $shareName eq "" ) {
print(LOG $bpc->timeStamp,
"unexpected empty share name skipped\n");
@@ -643,6 +641,8 @@
"unexpected repeated share name $shareName skipped\n");
next;
}
+ $stat{xferOK} = $stat{hostAbort} = undef;
+ $stat{hostError} = $stat{lastOutputLine} = undef;
$shareDuplicate->{$shareName} = 1;
UserCommandRun("DumpPreShareCmd", $shareName);
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
BackupPC-devel mailing list
BackupPC-devel@lists.sourceforge.net
List: https://lists.sourceforge.net/lists/listinfo/backuppc-devel
Wiki: http://backuppc.wiki.sourceforge.net
Project: http://backuppc.sourceforge.net/
