AUF - J r me Santini writes:

> Craig Barratt a écrit :
> > AUF - J r me Santini writes:
> > 
> > 
> >>I just installed backuppc today. All went fine until I added my nfs 
> >>fileserver to the list of host to be backuped
> >>
> >>When I try to backup this server, it fail each time on the same user 
> >>directory. attached are the end of the xferlog I get, with the error, 
> >>and an "ls" of the user directory. Note that some of the file have some 
> >>\n and somtimes even some \n\n : could this be the source of the problem 
> >>? what should I do ?
> > 
> > 
> > Yes - it looks like the newline in the file name is the problem.
> > The File::RsyncP code is meant to be robust to this, but it looks
> > like the communication between the two rsync processes doesn't
> > protect new lines.
> 
> what would the solution, then ? do you mean the problem would be with 
> rsync itself ?

No, the problem is with lib/BackupPC/Xfer/RsyncFileIO.pm.
Try this patch.

Craig

--- lib/BackupPC/Xfer/RsyncFileIO.pm.orig       2006-01-27 23:22:16.501056000 
-0800
+++ lib/BackupPC/Xfer/RsyncFileIO.pm    2006-01-27 23:25:13.155072000 -0800
@@ -736,23 +736,23 @@
     my $owner = "$f->{uid}/$f->{gid}";
     my $type  = (("", "p", "c", "", "d", "", "b", "", "", "", "l", "", "s"))
                    [($f->{mode} & S_IFMT) >> 12];
-    my $link;
+    my $name = $f->{name};
 
     if ( ($f->{mode} & S_IFMT) == S_IFLNK ) {
-        $link = " -> $f->{link}";
-    } if ( ($f->{mode} & S_IFMT) == S_IFREG
+        $name .= " -> $f->{link}";
+    } elsif ( ($f->{mode} & S_IFMT) == S_IFREG
             && defined($f->{hlink}) && !$f->{hlink_self} ) {
-        $link = " -> $f->{hlink}";
+        $name .= " -> $f->{hlink}";
     }
+    $name =~ s/\n/\\n/g;
 
-    $fio->log(sprintf("  %-6s %1s%4o %9s %11.0f %s%s",
+    $fio->log(sprintf("  %-6s %1s%4o %9s %11.0f %s",
                                $action,
                                $type,
                                $f->{mode} & 07777,
                                $owner,
                                $f->{size},
-                               $f->{name},
-                                $link));
+                                $name));
 }
 
 #


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
BackupPC-users mailing list
BackupPC-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/backuppc-users
http://backuppc.sourceforge.net/

Reply via email to