Hello:

Not sure of this is fixed in the latest beta release, but line 779 of
BackupPC_dump looks wierd. It appears to have unbalanced " marks.
It reads:

      $XferLOG->write(\"$logMsg\n");

but I claim it should read:

     $XferLOG->write("$logMsg\n");

Once I fixed this the syntax highlighting in emacs worked again 8-).
Well until the next invoaction. This appears to be a common calling
method.

I'm not quite sure how it gets through the perl parser, but...

Also when running with 'perl -w', BackupPC_dump throws a number of
warnings including:

  "my" variable $str masks earlier declaration in same scope at
  /tools/BackupPC-3.1.0beta0/lib/BackupPC/Xfer/BackupPCd.pm line 200.

Plus there are warnings:

  Statement unlikely to be reached at
  /tools/BackupPC-3.1.0beta0/bin/BackupPC_dump line 708.
        (Maybe you meant system() when you said exec()?)

about using exec from code like:

       exec("$BinDir/BackupPC_tarExtract", $client, $shareName,
                     $Conf{CompressLevel});
       print(LOG $bpc->timeStamp,
                      "can't exec $BinDir/BackupPC_tarExtract\n");
       exit(0);

that can be suppressed by writing it as:

     { no warnings qw(io);
       exec("$BinDir/BackupPC_tarExtract", $client, $shareName,
                    $Conf{CompressLevel});
       print(LOG $bpc->timeStamp,
                    "can't exec $BinDir/BackupPC_tarExtract\n");
      exit(0);
    }

which suppresses the exec warning just for the block, or by
using:

       {  exec("$BinDir/BackupPC_tarExtract", $client, $shareName,
                    $Conf{CompressLevel})  };
       print(LOG $bpc->timeStamp,
                    "can't exec $BinDir/BackupPC_tarExtract\n");

to hide it from the perl lexical warning analyzer.

-- 
                                -- rouilj

John Rouillard
System Administrator
Renesys Corporation
603-643-9300 x 111

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
BackupPC-users mailing list
[email protected]
List:    https://lists.sourceforge.net/lists/listinfo/backuppc-users
Wiki:    http://backuppc.wiki.sourceforge.net
Project: http://backuppc.sourceforge.net/

Reply via email to