Michael,

Thanks for the feedback.

On (1) I pushed a change
<https://github.com/backuppc/backuppc/commit/69e44286c8ff66eff0e7e1ef8ed052945b0018a8>
so that the Xfer timeout is started after backup expiry, duplication and
refcounting.

On (2), perhaps it should ignore a partial or active backup (which will
have the most recent timestamp), and report just the most recent incr or
full (ie, completed) backup?  I pasted a diff that should do the trick if
you want to try it out (warning - untested).

On (3), I pushed a change
<https://github.com/backuppc/backuppc/commit/19365d23cd4523874e2335db23eb7a89fa91253d>
so that the status reporting is more accurate.

Craig

--- lib/BackupPC/CGI/Summary.pm 2018-03-10 16:38:37.195549979 -0800
+++ lib/BackupPC/CGI/Summary.pm 2018-10-22 20:52:50.573850716 -0700
@@ -27,7 +27,7 @@
 #
 #========================================================================
 #
-# Version 4.2.0, released 18 Feb 2018.
+# Version 4.2.2, released 21 Oct 2018.
 #
 # See http://backuppc.sourceforge.net.
 #
@@ -70,7 +70,7 @@
                     $fullDur  = $Backups[$i]{endTime} -
$Backups[$i]{startTime};
                 }
                 $fullSizeTot += $Backups[$i]{size} / (1024 * 1024);
-            } else {
+            } elsif ( $Backups[$i]{type} eq "incr" ) {
                 $incrCnt++;
                 if ( $incrAge < 0 || $Backups[$i]{startTime} > $incrAge ) {
                     $incrAge = $Backups[$i]{startTime};


On Thu, Aug 30, 2018 at 3:22 AM Michael Selway <ma...@ssl.co.uk> wrote:

> Hi,
> I've recently upgraded from BackupPC v3.3.1 to v4.2.1 on a CentOS 7
> machine using hobbes1069's excellent COPR v4 package.  While the
> experience is fresh in my mind, I have some observations to share.
>
> 1) It has taken around 4 weeks for the v4 system to complete the first
> round of backups - the great bulk of that time is spent in v3->v4
> copying during the first v4 backup.  Right at the end of some of these
> first v4 backups, the backup is flagged as having failed.  The host LOG
> file says (for example):
>    2018-08-08 08:10:32 Got fatal error during xfer (total size is
> 466869877613  speedup is 23.88)
>
> The XferLOG says:
>    Got fatal error during xfer (total size is 466869877613  speedup is
> 23.88)
>    Backup aborted by user signal
>
> As far as I know, this is a bogus report and the backup was actually
> fine.  A subsequent backup starts from this Partial backup and completes
> successfully, running (of course) much faster than the first "failed"
> backup.  My guess is that the failure is caused by a ClientTimeout alarm
> signal 72000 seconds after the backup starts, which arrives during the
> v3->v4 copy.  The LOG file reports this:
>    2018-08-01 22:56:17 Aborting backup up after signal ALRM
>
> Thankfully it doesn't abort - it continues with the entire
> copy/backup/refcount/... process.
>
> 2) Backups which are still running or which have failed show up on the
> Host Summary web page with a recent Last Backup (days) value.  This
> makes it look (to me) like the backup has completed successfully.  I
> often use Host Summary sorted on the Last Backup column to see if any
> filesystems are lacking recent backups, and that doesn't work now
> because failed and still-running backups appear to be safely completed.
> I think this is a change from v3.
>
> 3) I noticed that when BackupPC_nightly was running
> "BackupPC_refCountUpdate -m", the BackupPC status web page said "v3
> cpool scan - cntUpdate nn/nn".  This makes it look like the v3 cpool
> scan is still running - I think the reported status is incorrect during
> this phase of the nightly process.
>
> Overall v4 is so much faster than v3 and just as brilliantly conceived
> and implemented - huge thank-you to Craig and anyone else involved for a
> fantastic piece of software.
>
> Michael.
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> BackupPC-users mailing list
> BackupPC-users@lists.sourceforge.net
> List:    https://lists.sourceforge.net/lists/listinfo/backuppc-users
> Wiki:    http://backuppc.wiki.sourceforge.net
> Project: http://backuppc.sourceforge.net/
>
_______________________________________________
BackupPC-users mailing list
BackupPC-users@lists.sourceforge.net
List:    https://lists.sourceforge.net/lists/listinfo/backuppc-users
Wiki:    http://backuppc.wiki.sourceforge.net
Project: http://backuppc.sourceforge.net/

Reply via email to