Hi Craig,
First, thanks again for adding the variable
"$Conf{RsyncRestoreArgsExtra} = [];

Now that such a variable is available both for backups and restores, wouldn't 
it make sense to move
the comments found in RsyncArgs and RsyncRestoreArgs to RsyncArgsExtra and 
RsynRestoreArgsExtra where they now more properly belong???
Indeed, in the documentation of those arguments, you specifically site --acls 
and --xattrs as potential extras?

   #
   # Add additional arguments here, for example --acls or --xattrs
   # if all the clients support them.
   #
   #'--acls',
   #'--xattrs',
                       

    #
    # Add additional arguments here
    #
    #'--acls',
    #'--xattrs',


Second, in BackupPC_restore, you have the following comment:
        #
        # Run an optional pre- or post-dump command
        #
        sub UserCommandRun
        {

I believe the word 'restore' should be substituted for dump :)



_______________________________________________
BackupPC-users mailing list
BackupPC-users@lists.sourceforge.net
List:    https://lists.sourceforge.net/lists/listinfo/backuppc-users
Wiki:    https://github.com/backuppc/backuppc/wiki
Project: https://backuppc.github.io/backuppc/

Reply via email to