Hello Eric,

A recent "subtle" change to dird/ua_cmds.c causes at least one (possibly more) 
regression scripts to fail.  I haven't checked, but I suspect that you made 
the change when you were fixing Andreas' SQL problems.

Basically, the change forces the Recycle Pool to be the default value as 
defined by the pool.  Previously the Recycle Pool was considered something to 
be Volume dependent, and thus was not reset during normal volume operations 
(i.e. moving from pool to pool).

The consequences of this change are if you set the Scratch volumes to return 
to the Scratch pool when they are recycled, they do not.  Although I can see 
that users might want a way to force Scratch volumes to remain in the Pool 
where they are used, I don't think this will be the default.

In any case, it breaks the current regression scripts, which count on Scratch 
volumes coming back to the Scratch pool (providing the Scratch pool has 
itself set a Recycle Pool).

Now, my question is:  was this change absolutely necessary to fix Andreas' 
problem.  If so, could you explain it to me so that I understand.  If not, do 
you have any objection to me putting it back.

What happens is the following:

Scratch Pool
  Volume X , Recycle Pool = Scratch Pool

Volume X moved to Default Pool
  Default Pool has Recycle Pool = NULL
  Volume X Recycle Pool set to NULL  (previously it was unchanged)

Volume X recycled and left in Default Pool
   
The regression script blocks because there are no more volumes in Inc pool and 
no Scratch Volumes.  So with the new code, there is no way to make the Volume 
come back to the Scratch pool.  With the old code, if the user set or left:

  Volume X , Recycle Pool = NULL

then when it was moved to the Default Pool, it would have remained in the 
Default pool when it was recycled because a NULL Recycle Pool means to leave 
it in the same pool.



Best regards,

Kern

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Bacula-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bacula-devel

Reply via email to