On Thursday 19 July 2007 13:47, BOLLENGIER Eric wrote:
> > > > What happens is the following:
> > > >
> > > > Scratch Pool
> > > > Volume X , Recycle Pool = Scratch Pool
> > > >
> > > > Volume X moved to Default Pool
> > > > Default Pool has Recycle Pool = NULL
> > > > Volume X Recycle Pool set to NULL (previously it was unchanged)
> > >
> > > "Previously" means before the recyclepool patch ? or before andreas
fix ?
> >
> > That is a good question. I think it means before the Andreas fix, but am
> > not sure. I would need to look back at the SVN to see whether it was you
> > or me who added setting the RecyclePool in
> > set_pool_dbr_defaults_in_media_dbr(). As far as I can see, that was a good
> > change that should be left in, but it is what broke the regression
scripts.
>
> RecyclePool function is a new option from the 2.2 release. Fields where
> present in the 2.0, but they were not used.
>
> > I have added code to next_vol.c that resets the RecyclePoolId after the
> > call to set_pool_dbr_defaults_in_media_dbr(), which seems to correct the
> > problem.
>
>
> Sorry, but i don't see the problem, move a volume from the scratch
> must update the RecyclePool field.
>
> For example, you put a volume into the 5 year retention pool, but
> you don't want reuse it after this period. You will use something like
>
> Pool {
> Name = 5YEAR
> ...
> RecyclePool = TrashPool
> }
>
>
> With your new algo, RecyclePool must be set by user per volume.
The problem was that the RecyclePool for the volume was destroyed when moving
it to another Pool.
I think it is fixed now.
>
> > > > Volume X recycled and left in Default Pool
> > >
> > > I think it's logical...
> > >
> > > RecyclePool is like other pool attributes, you can set what you want per
> > > volume, but when it comes from the scratch, it takes attributes from the
> > > new pool.
> > >
> > > If you don't use RecyclePool in your pool definition, media will not
> > > return
> >
> > to
> >
> > > the Scratch.
> >
> > Well, that is not how the code was working. RecyclePool was set in
> > Scratch, but not in Default, and the media did not return to the Scratch
> > pool.
>
> Which test is broken, i think we have to adapt it (since it's a new
option) ?
What was broken was the three-pool-test. It works now with my patch to the
SVN.
>
>
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Bacula-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bacula-devel
