On Thursday 19 July 2007 14:09, BOLLENGIER Eric wrote:
>
> >From the manual :
> >From the manual :
>
http://www.bacula.org/dev-manual/Configuring_Director.html#SECTION0014160000000000000000
>
> RecyclePool = <pool-resource-name>
> On versions 2.1.4 or greater, this directive defines to which pool the
> Volume will be placed (moved) when it is recycled. Without this directive, a
> Volume will remain in the same pool when it is recycled. With this
directive,
> it can be moved automatically to any existing pool during a recycle. This
> directive is probably most useful when defined in the Scratch pool, so that
> volumes will be recycled back into the Scratch pool. For more on the see the
> Scratch Pool section of this manual.
Yes, that is exactly it. The Volumes were pulled out of the Scratch pool, but
never recycled back into the scratch pool as the documentation says.
That happened because the default pool attributes from the new pool were
applied when moving the volume out of the Scratch pool.
I've fixed it now.
>
>
> An example :
>
> Pool {
> Name = Default
> ...
> RecyclePool = Scratch
> }
>
> Pool {
> Name = Week
> # no recyclepool
> ...
> }
>
> Pool {
> Name = 10Years
> RecyclePool = Trash
> ...
> }
>
> Pool {
> Name = Scratch
> ...
> }
>
> Pool {
> Name = Trash
> ...
> }
>
>
> When Default pool needs a volume, it will take a new one from Scratch, and
> the RecyclePool will be set to "Scratch".
>
> When a volume from Default pool will be purged, the volume will go to the
> Scratch. (RecyclePool will not change, it doesn't matter)
>
> When 10Years pool needs a volume, it will take a new one from Scratch, and
> will go (and stay) to Trash when it will be purged.
>
> When Week pool needs a volume, it will be take from Scratch, and will stay
> forever in this pool. Because, user don't have set RecyclePool= option.
>
>
> This option is designed for that, nothing else.
Well, I have changed the behavior you expect to correspond to how most other
parameters of a Volume are handled. The Recycle Pool is set when a Volume is
created, but not changed when it is recycled into the new pool.
>
> On Thursday 19 July 2007 13:47:55 BOLLENGIER Eric wrote:
> > > > > What happens is the following:
> > > > >
> > > > > Scratch Pool
> > > > > Volume X , Recycle Pool = Scratch Pool
> > > > >
> > > > > Volume X moved to Default Pool
> > > > > Default Pool has Recycle Pool = NULL
> > > > > Volume X Recycle Pool set to NULL (previously it was unchanged)
> > > >
> > > > "Previously" means before the recyclepool patch ? or before andreas
fix
> > > > ?
> > >
> > > That is a good question. I think it means before the Andreas fix, but
am
> > > not sure. I would need to look back at the SVN to see whether it was
you
> > > or me who added setting the RecyclePool in
> > > set_pool_dbr_defaults_in_media_dbr(). As far as I can see, that was a
> > > good change that should be left in, but it is what broke the regression
> > > scripts.
> >
> > RecyclePool function is a new option from the 2.2 release. Fields where
> > present in the 2.0, but they were not used.
> >
> > > I have added code to next_vol.c that resets the RecyclePoolId after the
> > > call to set_pool_dbr_defaults_in_media_dbr(), which seems to correct the
> > > problem.
> >
> > Sorry, but i don't see the problem, move a volume from the scratch
> > must update the RecyclePool field.
> >
> > For example, you put a volume into the 5 year retention pool, but
> > you don't want reuse it after this period. You will use something like
> >
> > Pool {
> > Name = 5YEAR
> > ...
> > RecyclePool = TrashPool
> > }
> >
> >
> > With your new algo, RecyclePool must be set by user per volume.
> >
> > > > > Volume X recycled and left in Default Pool
> > > >
> > > > I think it's logical...
> > > >
> > > > RecyclePool is like other pool attributes, you can set what you want
> > > > per volume, but when it comes from the scratch, it takes attributes
> > > > from the new pool.
> > > >
> > > > If you don't use RecyclePool in your pool definition, media will not
> > > > return
> > >
> > > to
> > >
> > > > the Scratch.
> > >
> > > Well, that is not how the code was working. RecyclePool was set in
> > > Scratch, but not in Default, and the media did not return to the Scratch
> > > pool.
> >
> > Which test is broken, i think we have to adapt it (since it's a new
option)
> > ?
> >
> >
> >
> > -------------------------------------------------------------------------
> > This SF.net email is sponsored by DB2 Express
> > Download DB2 Express C - the FREE version of DB2 express and take
> > control of your XML. No limits. Just data. Click to get it now.
> > http://sourceforge.net/powerbar/db2/
> > _______________________________________________
> > Bacula-devel mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/bacula-devel
>
>
>
> --
> Eric BOLLENGIER, Administrateur Système - Poste 1325
> SIGMA Informatique http://www.sigma.fr
> 3 rue Newton, BP 4127, 44241 La Chapelle sur Erdre Cedex
> tel : 02.40.37.14.00
>
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Bacula-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bacula-devel
