On 22 Aug 2007 at 13:37, Martin Simmons wrote: > >>>>> On Wed, 22 Aug 2007 13:50:22 +0200, BOLLENGIER Eric said: > > > > On Wednesday 22 August 2007 13:22:13 Martin Simmons wrote: > > > >>>>> On Wed, 22 Aug 2007 07:06:51 -0400, Dan Langille said: > > > > > > > > On 22 Aug 2007 at 10:35, BOLLENGIER Eric wrote: > > > > > On Wednesday 22 August 2007 02:58:15 Dan Langille wrote: > > > > > > On 21 Aug 2007 at 23:34, Eric Bollengier wrote: > > > > > > > Hello, > > > > > > > > > > > > > > Yes, bacula is using PQescapeString which is an older, deprecated > > > > > > > version of PQescapeStringConn. We have to use the new version to > > > > > > > avoid this message, but it's not so easy at this time :) > > > > > > > > > > > > > > It's in my todo list. > > > > > > > > > > > > I'll do it. > > > > > > > > > > Ok, you have to modify the db_escape_string prototype > > > > > to something like > > > > > > > > > > db_escape_string(B_DB *mdb, char *snew, char *old, int len) > > > > > > > > > > to be able to use mdb->db in PQescapeStringConn. > > > > > > > > I'll start this today. > > > > > > Can you make it automatically use PQescapeString if the version of > > > PostgreSQL does not have PQescapeStringConn? > > > > > > > > > PQescapeString is appear in 7.2 and was deprecated in 7.3 > > > > I don't think it's a good idea to support postgresql before 7.3. > > (postgresql 7.2 and previous are not supported by postgresql team) > > The problem is that PQescapeStringConn is not available in all 7.3.x.
We already support only PostgreSQL >= 7.3: http://www.bacula.org/rel-manual/Installi_Configur_PostgreS.html However, PQescapeStringConn was not added until 7.3.15. I don't have a problem adjusting the PostgreSQL requirements, but it is something we should actively publicize before the next release. If it affects anyone, it would be only a few people. And if they're upgrading Bacula without upgrading PostgreSQL. We could just bite the bullet and change our requirements to PostgreSQL 7.4 -- Dan Langille - http://www.langille.org/ Available for hire: http://www.freebsddiary.org/dan_langille.php ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Bacula-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/bacula-devel
