On Thursday 04 October 2007 19:12, Marc Levy wrote: > Hi, > I was having some problems with bsmtp when specifying a human friendly > email address in the -f command line argument (ie: "Mr John Doe > <[EMAIL PROTECTED]>"): the SMTP server was always adding > '<[EMAIL PROTECTED]>' to the 'RCPT to:' list. > The problem comes from the cleanup_addr function: (due to a typo > and/or a fast copy/paste) in the current bsmtp.c code (v 2.2.4) the > strchr function at line 82 is always working with the same string > 'from_addr' witch ever string is passed to cleanup_addr function call > (via the 'addr' argument). > The obvious attached patch (bsmtp.diff) correct this by simply > replacing 'from_addr' by 'addr' (ie inside cleanup_addr the local > 'addr' always points to the string given in parameter while the > "global" 'from_addr' always points to ..... the same string!
Yes, thanks for the patch. It was as you indicated, simply a bug introduced by a cut and paste "typo". Your fix is correct, and I have added it to the code base, and it will be in version 2.2.5. Thanks, Kern ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Bacula-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/bacula-devel
