On Sunday 11 January 2009 18:05:41 Dan Langille wrote:
> I have a list of casting patches, based upon testing with FreeBSD 7.x
> and gcc 4.2.1.
>
> If this looks good to y'all, I'll commit them later today:
No, it looks too ugly.
I would much rather modify the basic type on the variable. The casting with
the translation macro is just too ugly.
example: change "char *prt_type" to "const char *prt_type" or whatever silly
order of the char and const it takes to quiet the stupid compiler. These
compiler guys have really made a terrible design decision that is costing
millions of lines of changes for nothing -- I think the guy that made the
decision to define all "xxx" strings as const was educated at Microsoft.
Doing so may create other problems where prt_type is referenced, but if we can
work them all out it is a much better way to do it.
Regards,
Kern
>
> NOTE: the following is a copy/paste and probably won't act well as a patch:
>
> $ svn di
> Index: src/dird/ua_update.c
> ===================================================================
> --- src/dird/ua_update.c (revision 8352)
> +++ src/dird/ua_update.c (working copy)
> @@ -360,7 +360,7 @@
> } else { /* update volume recyclepool="" */
> /* If no pool name is given, set the PoolId to 0 (the default) */
> mr->RecyclePoolId = 0;
> - poolname = _("*None*");
> + poolname = (char *)_("*None*");
> }
>
> db_lock(ua->db);
> Index: src/dird/ua_run.c
> ===================================================================
> --- src/dird/ua_run.c (revision 8352)
> +++ src/dird/ua_run.c (working copy)
> @@ -941,9 +941,9 @@
> case JT_MIGRATE:
> char *prt_type;
> if (jcr->get_JobType() == JT_COPY) {
> - prt_type = _("Run Copy job\n");
> + prt_type = (char *)_("Run Copy job\n");
> } else {
> - prt_type = _("Run Migration job\n");
> + prt_type = (char *)_("Run Migration job\n");
> }
> jcr->set_JobLevel(L_FULL); /* default level */
> if (ua->api) ua->signal(BNET_RUN_CMD);
> Index: src/stored/read_record.c
> ===================================================================
> --- src/stored/read_record.c (revision 8352)
> +++ src/stored/read_record.c (working copy)
> @@ -132,10 +132,10 @@
> char *fp;
> uint32_t fp_num;
> if (dev->is_dvd()) {
> - fp = _("part");
> + fp = (char *)_("part");
> fp_num = dev->part;
> } else {
> - fp = _("file");
> + fp = (char *)_("file");
> fp_num = dev->file;
> }
> Jmsg(jcr, M_INFO, 0, _("End of %s %u on device %s,
> Volume \"%s\"\n"),
> Index: src/stored/askdir.c
> ===================================================================
> --- src/stored/askdir.c (revision 8352)
> +++ src/stored/askdir.c (working copy)
> @@ -603,13 +603,13 @@
> if (!dev->poll && (stat == W_TIMEOUT || stat == W_MOUNT)) {
> char *msg;
> if (mode == ST_APPEND) {
> - msg = _("Please mount Volume \"%s\" or label a new one for:\n"
> + msg = (char *)_("Please mount Volume \"%s\" or label a new
> one for:\n"
> " Job: %s\n"
> " Storage: %s\n"
> " Pool: %s\n"
> " Media type: %s\n");
> } else {
> - msg = _("Please mount Volume \"%s\" for:\n"
> + msg = (char *)_("Please mount Volume \"%s\" for:\n"
> " Job: %s\n"
> " Storage: %s\n"
> " Pool: %s\n"
>
>
> ---------------------------------------------------------------------------
>--- Check out the new SourceForge.net Marketplace.
> It is the best place to buy or sell services for
> just about anything Open Source.
> http://p.sf.net/sfu/Xq1LFB
> _______________________________________________
> Bacula-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/bacula-devel
------------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It is the best place to buy or sell services for
just about anything Open Source.
http://p.sf.net/sfu/Xq1LFB
_______________________________________________
Bacula-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bacula-devel
