Hello,
After looking over your VituralCopy code and thinking about this, I am
convinced that we are going in the right direction, but possibly if we change
some of the details, it will be slightly more logical for users.
Our current situation is:
Type=Backup
Level=VirtualFull
produces a new Full backup, but by reading old Volumes
Type=Migration
Level=
always forced to Full
Type=Copy
Level=
always forced to Full
Now, it seems to me that from a user point of view what we might be best is a
Type=Copy job with a Level=VirtualFull. The problem is that as you certainly
know, it is probably easier to wedge the code into a Bacula Job as you have
done rather than a Copy or Migration Job since the code for those two types
of jobs is much more complex.
So, what I recommend is the following:
Modify the Migrate/Copy code (src/dird/migrate.c) to detect Level=VirtualFull,
and in that case to call the vbackup.c code (as the backup.c code currently
does. If you implement it for Type=Migrate (not necessary at the current
time), it would need to do the same thing as Type=Backup, Level=VirtualFull,
but delete the original Jobs as the migration code does. For the Copy code,
the only thing is to mark the copies as copies (in vbackup.c --
vbackup_cleanup()) in the same way the Copy code does it.
I haven't spent enough time on this to know what this change would do to your
code (i.e. whether it is a big change or a small change -- my gut feeling is
that it is a big simplification), but at least on the surface from a user
standpoint, it eliminates a new "VirtualCopy" concept and simply extends the
existing Copy concept.
What do you think?
Is this something you would like to work on?
Comments from anyone else?
Best regards,
Kern
On Tuesday 23 June 2009 20:07:28 Jonathan Bayer wrote:
> Hi Kern,
>
> After getting your messages, I thought I'd look at the code and see if I
> could modify it for my purposes.
>
> After reading some of the docs again, I realized that what I really
> needed to do is to first do a VirtualFull job, then a Copy job. Given
> the lack of disk space, I decided to go a different route:
>
> I've created a new type of backup which I'm calling (for now) a
> VirtualCopy. Essentially what this does is to do a VirtualFull backup,
> but then marks it as a copy.
>
> So far in my testing it works well. I have tested it both from bconsole
> and as an automated job.
>
> The attached patch file is against the 3.0.1 version. I have tested the
> patch file with a clean download.
>
> I look forward to hearing from you about this.
>
>
>
> JBB
------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
Bacula-devel mailing list
Bacula-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-devel
