On Wednesday 15 July 2009 17:36:54 Eli Shemer wrote: > Hey again > > > > savecwd.c > > The call to fchdir() should be prefixed with #ifdef HAVE_FCHDIR
I don't see why. As far as I know, it needed and used in Windows -- at least in my builds there are no problems. > > The macro is indeed set correctly (or rather not set;) in winconfig.h > but we failed to check prior to the actual call to the function. > > > > find_one.c > > > > #if !defined(HAVE_WIN32) || defined(HAVE_MINGW) > > #include <sys/param.h> > > #endif > > > > Should be changed to > > > > #if !defined(HAVE_WIN32) || defined(HAVE_MINGW) > > #include <sys/param.h> > > #else > > #define MAXPATHLEN <num> > > #endif > > > > What do you want it set to ? 4096 ? Since you are likely to find a number of problems, because you are essentially trying to port the code to another operating system, I think what would be more productive would be for you to make all your modifications, then test to make sure that the cross compile still works correctly with them applied, and finally, send us a patch in the standard patch format. However, please be aware that we do not like #ifdefs especially inside the flow of the code, so we attempt to avoid them wherever possible, and in fact are trying to remove many of the current ones we have. As a consequence if you find yourself adding lots of #ifdefs, something is wrong and you will need to use a different technique or risk not having the patch applied. We often put the #ifdef at the top of the file and use const int to define a variable that can be used in an if statement so that the code does not become unreadable because of #ifdefs. Of course, if you find a "bug" or something really broken such as the CONFIG::init() problem, we would like to hear about it now. ------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ Bacula-devel mailing list Bacula-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bacula-devel
