On Monday 16 November 2009 18:08:13 SF Markus Elfring wrote: > Hello, > > I pointed out that some function interfaces are not const-correct so far. > http://bugs.bacula.org/view.php?id=1408
In general, I don't mind cleaning up the const correctness, but we are not terribly fanatic about it. We are stull using g++ 4.2.4, and we have already seen that 4.4.x is a lot more picky, so eventually we will clean up at a minimum everything that 4.4. complains about. > > We have got different opinions on the effect that the addition of the key > word "const" will have on the software design in several places of the > source files. Perhaps. As I say, it is something that I don't find critical, but the more correct it is the better. In all my 48 years of programming, I have never seen a case where putting the correct "const" would have avoided a bug, so it is a matter of priorities. > > I would like to show another update candidate. How do you think about an > adjustment for an interface like "lookup" in the class "htable"? Perhaps. The routines are a bit primitive so can certainly be improved. In fact, anyone who is a C++ programmer will not like them at all because one subroutine handles all types (with some casting). What is important is that they are fast. What did you have in mind for an "adjustment" -- it is hard to comment without knowing just what you are proposing. > http://bacula.git.sourceforge.net/git/gitweb.cgi?p=bacula/bacula;a=blob;f=b >acula/src/lib/htable.h;h=1341a7a2ce497cb5c8d9bf12755766b761e1af9e;hb=HEAD#l1 >02 By the way, I am leaving tomorrow morning for the US, so will be offline much of the time until late this weekend. Best regards, Kern PS: One final note, we are now in a "code feature freeze" for releasing the next version, which means that we are still completing a couple of features that are planned, but in general, we are not adding any new features or making changes that could potentially disruptive. That won't prevent us from doing some cleanup in a branch to be merged after the release or could be merged before the release if it is 100% certain not to introduce new bugs ... ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Bacula-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/bacula-devel
