> The design choice is to not worry about some unlikely errors providing > it is not important. In important cases for proper functioning of Bacula > we should check.
How do you think about the ignorance of the return value "(off_t)-1" from the function call "lseek" in the following examples? - bdb_write_control_file: http://bacula.git.sourceforge.net/git/gitweb.cgi?p=bacula/bacula;a=blob;f=bacula/src/cats/bdb.c;h=9eecde839e2fe4a5524e3ec5f2b74a772a4ee391;hb=HEAD#l119 - read_block_from_dev: http://bacula.git.sourceforge.net/git/gitweb.cgi?p=bacula/bacula;a=blob;f=bacula/src/stored/block.c;h=7899621399baae42242e1b392e32105c8688d650;hb=HEAD#l1087 - lseek_dvd: http://bacula.git.sourceforge.net/git/gitweb.cgi?p=bacula/bacula;a=blob;f=bacula/src/stored/dvd.c;h=0496359b4a48b6f940595836754e61b266d052d4;hb=HEAD#l450 I guess that more open issues can also be found by tools for static source code analysis. Regards, Markus ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Bacula-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/bacula-devel
