Hello,

I find the following instructions strange in your function "e_msg".
http://bacula.git.sourceforge.net/git/gitweb.cgi?p=bacula/bacula;a=blob;f=bacula/src/lib/message.c;h=5791f6b51b95a43be565ad351630d7e48dd24029;hb=HEAD#l1078

    if (type == M_ABORT) {
       char *p = 0;
       p[0] = 0;                      /* generate segmentation violation */
    }


I would prefer to call the standard function "abort" explicitly.

The article "Fun with NULL pointers" by Jonathan Corbet has got a few more 
informations to consider for this implementation detail. 
http://lwn.net/Articles/342420/

How do you think about to make it clearer that null pointer dereferences can 
only occur at other places of your source code?

Regards,
Markus

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Bacula-devel mailing list
Bacula-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-devel

Reply via email to