Hello, I am sorry, but it is taking too much of my time to respond to you, and the issues you are pointing out are non-issues because the Bacula code is structured very different from what you think it is. The errors that are generated by those calls if any are reported and noted, and Bacula will shutdown communications shortly there after and the job will be failed. The error is not at all ignored, it is just that within Bacula not all calls need be checked. In many places it is not even really clear exactly what one would do.
So, I think you are wasting your time for the most part pointing these out. We know about them, we wrote it that way, all is OK, because they are handled or will be handled shortly thereafter. The only downside is that occassionally Bacula will print a few more error messages than is necessary. If you find something that is really a bug or is worth fixing, then it is probably worth fixing, otherwise it isn't worth it -- such as your example of not checking the return pointer from malloc(). Even if the system is totally out of memory, in Bacula it is not possible to get a return from malloc with a NULL pointer, so why check for it. This will be clear if you look carefully at our code, and even after I mentioned this to you, you brought it up again. Please look at the bugs list pick one and fix it. That will be a real help to the project. Many thanks, Kern Best regards, Kern On Thursday 19 November 2009 09:07:23 SF Markus Elfring wrote: > > The design choice is to not worry about some unlikely errors providing > > it is not important. In important cases for proper functioning of Bacula > > we should check. > > I see it as a matter of service quality if the return value of the member > function "BSOCK::fsend" is ignored at places like the following. - > authenticate_director: > > http://bacula.git.sourceforge.net/git/gitweb.cgi?p=bacula/bacula;a=blob;f=b >acula/src/console/authenticate.c;h=2297943b98ff948935728c461a1bf7d452191162; >hb=HEAD#l116 > > - accurate_list_handler: > > http://bacula.git.sourceforge.net/git/gitweb.cgi?p=bacula/bacula;a=blob;f=b >acula/src/dird/backup.c;h=eb8e9f121751002b5fcf7bb4414b431a5993c143;hb=HEAD#l >160 > > - status_cmd: > > http://bacula.git.sourceforge.net/git/gitweb.cgi?p=bacula/bacula;a=blob;f=b >acula/src/stored/status.c;h=11939fb247c99b873501a2505ac0436c81283488;hb=HEAD >#l678 > > Would you like to be sure that all data was successfully transferred to the > target? > > Regards, > Markus ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Bacula-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/bacula-devel
