Hi, Le samedi 09 janvier 2010 à 21:02 +0100, Eric Bollengier a écrit : > Hi, > > Le samedi 09 janvier 2010 20:22:06, Renaud Marquet a écrit : > > Kern, > > > > altough I searched for a possible workaround, I didn't found the ones > > you talk about. But your statement is not correct as pointing to a valid > > smtp server is not a proper workaround. Actually, if for some reason, > > the *valid* smtp server is down, the problem will occur and I bet users > > will not figure out the reason. > > IMHO, I think that it's much more safer to run a small smtp server on > localhost rather than using your patch...
Once again, this smtp server, even on localhost, could be down and the problem would occur. However, I agree with you that having a local smtp server greatly reduces the risk, but it's certainly not safer. This patch, although it have some performances issues, is completely safe as it simply add a safety check to mutex acquisition : if *current* thread has already acquired mutex, return ok. > > > That's why I came up with this patch. It correctly fixes the problem but > > I recognize this could affect performances so it should certainly not be > > put in the trunk. It will even probably be useless as you pointed out > > it's already fixed in developpement version. > > > > That said, I didn't know lock manager should be turned off in production > > environment. Moreover, I'm not sure I understand your point because, > > although I didn't read all the code, it seems pretty strange to me that > > a multithreaded application should not use any mutexes in a production > > environment. > > The lock manager is used to track problem with dead locks. Normal code just > use normal mutexes. I'm not well aware of this lock manager but I compiled bacula using standard procedure, so I guess it's probably not activated. However normal mutexes are acquired through a macro (P) which refers to a function in lockmgr.c > > Bye Regard. ------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ Bacula-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/bacula-devel
