>>>>> On Tue, 11 May 2010 02:22:53 -0400, Kern Sibbald said: > > On Tuesday 11 May 2010 01:42:15 Marc Cousin wrote: > > 2010/5/11 Dan Langille <[email protected]> > > > > > I'm seeing this error during regression testing: > > > > > > ==>Entering directory > > > /usr/home/dan/src/BaculaRegressionTesting-TRUNK/regress/build/src/cats > > > postgresql.c:50:78: error: pg_config_manual.h: No such file or directory > > > *** Error code 1 > > > > > > > > > It happens on PG 7.3 on FreeBSD. > > > > > > The above should be in the regression testing dashboard, but I don't see > > > it. > > > > > > Site: langille_pg73_postgresql_bacula_trunk > > > Build name: 5.0.2-28Apr10-postgresql-freebsd-8.0-STABLE > > > Determine Nightly Start Time > > > Specified time: 23:00:00 CET > > > Create new tag: 20100509-2200 - Nightly > > > Submit files (using http) > > > Using HTTP submit method > > > Drop site:http://regress.bacula.org/submit.php?project=bacula > > > Using HTTP trigger method > > > Trigger site: http://regress.bacula.org > > > Dart server triggered... > > > Submission successful > > > End nightly-disk Mon May 10 00:48:37 UTC 2010 > > > > Is PostgreSQL 7.3 still supported on bacula ? > > Not really because if I remember right, 7.4 does not support Batch Insert > mode. If a user submits a clean patch that makes it work OK, but otherwise, > we are very unlikely to look at the problem.
I was using PostgreSQL 7.3.4 successfully for a while with Batch Insert switched off in Bacula 5.0.1. The patch below was sufficient to make it compile, i.e. don't include pg_config_manual if NAMEDATALEN is already defined. This also works withg PostgreSQL 8.4 so I think it is clean. --- orig/bacula-5.0.1/src/cats/postgresql.c 2010-02-24 15:33:48.000000000 +0000 +++ bacula-5.0.1/src/cats/postgresql.c 2010-04-07 17:26:22.000000000 +0100 @@ -47,7 +47,9 @@ #ifdef HAVE_POSTGRESQL #include "postgres_ext.h" /* needed for NAMEDATALEN */ +#ifndef NAMEDATALEN #include "pg_config_manual.h" /* get NAMEDATALEN on version 8.3 or later */ +#endif /* ----------------------------------------------------------------------- * There were two other problems: - make_postgresql_tables failed because CREATE TABLE JobHisto (LIKE Job) is not supported. There is no clean patch for that, but I just created it using a copy of the command for the Job table. - db_add_digest_to_file_record and db_mark_file_record were very slow because the query optimizer failed to use the file_pkey index due to datatype mismatch. I hacked around that but the patch is not clean. __Martin ------------------------------------------------------------------------------ _______________________________________________ Bacula-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/bacula-devel
