Hi,
we have a need for a fileset that uses a client (fd) side script to print a
list of files to be backed up. This list depends on the backup level. The
syntax in question is "\|script". Unfortunately, at this time, the fd does not
know about the backup level at the time the file list(s) is (are) evaluated.
With the attached patch (vs. 5.0.3), the order of the respective calls is
modified; _first_ the level is sent to the fd, _then_ the file lists are
fetched. The patch is quite trivial.
At the first sight, my installation continues to run fine with the patch
applied. I can now successfully use "\|script %l".
1) Do I miss anything, or would you expect the patch to work well? I have not
tested "since" backup levels, migration, ...
2) Is there any chance of this patch being included upstream sooner or later?
Similar topic to be discussed in another mail/thread to follow.
Thx & best regards
Bastian
--
Collax GmbH . Basler Str. 115a . 79115 Freiburg . Germany
p: +49 (0) 89-990 157-28 www.collax.com
Geschäftsführer: Bernd Bönte, Boris Nalbach
AG München HRB 173695. Ust.-IdNr: DE270819312
With this patch, the level command is sent to the file daemon prior to the
include and exclude list evaluation. With this, the remote execution of
file listers (\| syntax) has access to the backup level.
diff -uNr bacula-5.0.3.ori/src/dird/backup.c bacula-5.0.3/src/dird/backup.c
--- bacula-5.0.3.ori/src/dird/backup.c 2010-08-05 16:29:51.000000000 +0200
+++ bacula-5.0.3/src/dird/backup.c 2011-08-29 11:39:14.000000000 +0200
@@ -384,15 +384,15 @@
jcr->setJobStatus(JS_Running);
fd = jcr->file_bsock;
- if (!send_include_list(jcr)) {
+ if (!send_level_command(jcr)) {
goto bail_out;
}
- if (!send_exclude_list(jcr)) {
+ if (!send_include_list(jcr)) {
goto bail_out;
}
- if (!send_level_command(jcr)) {
+ if (!send_exclude_list(jcr)) {
goto bail_out;
}
------------------------------------------------------------------------------
EMC VNX: the world's simplest storage, starting under $10K
The only unified storage solution that offers unified management
Up to 160% more powerful than alternatives and 25% more efficient.
Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
_______________________________________________
Bacula-devel mailing list
Bacula-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-devel
