Hi All, This is a follow up to bug id 1763[1]. It was suggested that a better fix was to define the URL as a macro and use the macro throughout the code anywhere that the authentication troubleshooting URL was referenced. I agree that this is a better fix, so here are the patches.
I inserted the macro MANUAL_AUTH_URL in baconfig.h which seemed to be a good choice, but maybe it should be somewhere else? The source files that included the URL directly were then updated to use the macro instead. The exception to this is the .po translation files. I hope this submission is acceptable (I'm not familiar with bacula patch submission other than through mantis). Comments and criticisms welcomed. Thanks -Ben [1] http://bugs.bacula.org/view.php?id=1763 Ben Walton (2): Define MANUAL_AUTH_URL in baconfig.h Update auth troubleshooting URL to use MANUAL_AUTH_URL macro bacula/src/baconfig.h | 2 ++ bacula/src/console/authenticate.c | 2 +- bacula/src/dird/authenticate.c | 4 ++-- bacula/src/filed/authenticate.c | 2 +- bacula/src/lib/bsock.c | 2 +- bacula/src/qt-console/bcomm/dircomm_auth.cpp | 2 +- .../src/qt-console/tray-monitor/authenticate.cpp | 6 +++--- bacula/src/stored/authenticate.c | 8 ++++---- bacula/src/tray-monitor/authenticate.c | 6 +++--- bacula/src/wx-console/authenticate.c | 2 +- 10 files changed, 19 insertions(+), 17 deletions(-) -- 1.7.4.1 ------------------------------------------------------------------------------ BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA http://p.sf.net/sfu/rim-devcon-copy2 _______________________________________________ Bacula-devel mailing list Bacula-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bacula-devel
