On 02/10/2012 06:08 PM, Alexander Fisher wrote: > On 10 February 2012 15:31, Kern Sibbald<k...@sibbald.com> wrote: >> You have good detective skills :-) > Thanks :) > >> The two patches from Jan 2012 are the essence of the fix. The >> problem is sometimes we commit a patch or two and then after more >> testing find another problem so make another patch. Those two look >> good at least as a start and I would give them 80% chance of being >> all that is required. Just the same, I recommend to grep the current source >> code, particularly in /src/lib and src/dird for any occurrences of >> set_killable >> If there are none, I would say 95% you have everything you need. > The debian squeeze source has no instances of set_killable, whilst the > latest source from git has some extra instances introduced in > f3a0ff8116933b7d469f7b95355083aaed07eb9d - but I think these are to > address a different seg fault that I've not personally encountered. > > I'll try the Jan 2012 patches and if I can no longer get the storage > daemon to seg fault, I'll attach them to my debian bug report. > > I'm not sure if they can be included in the next squeeze point > release, (I'll have to look up the policy on that), but would you > describe the changes as 'safe' and suitable for debian stable?
As long as you test it carefully, which means running the Bacula regression scripts, I would consider it a save patch because it just inhibits sending a signal, and it is the signal that apparently cause the crash. Every once in a while, and I don't think this is one of those cases, a seemingly simple change causes really unexpected problems. 95%+ of such cases are detected by running the regression scripts and ensuring that they all succeed. Best regards, Kern > > Kind Regards, > Alex > > ------------------------------------------------------------------------------ > Virtualization& Cloud Management Using Capacity Planning > Cloud computing makes use of virtualization - but cloud computing > also focuses on allowing computing to be delivered as a service. > http://www.accelacomm.com/jaw/sfnl/114/51521223/ > _______________________________________________ > Bacula-devel mailing list > Bacula-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/bacula-devel ------------------------------------------------------------------------------ Virtualization & Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ _______________________________________________ Bacula-devel mailing list Bacula-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bacula-devel
