Hello Phil,
Thanks for the patches and compiler warning output.
I think I have eliminated all the warnings you show below, with one
exception, which is changing the position of:
extern "C" char *tgoto (const char *, int, int);
As noted in the comments noted above, this is a particularity (bug) in Solaris
10. If you know some why to key it on Solaris 10 only, I will be happy to take
it, otherwise, the change will break more modern (and supported) versions of
Solaris.
I will commit these changes sometime today.
Best regards,
Kern
On 03/14/2017 07:12 PM, Phil Stracchino wrote:
> On 03/13/17 10:12, Phil Stracchino wrote:
>> I'm seeing lots of:
>>
>> Compiling verify_vol.c
>> "xacl.h", line 142: Warning: content hides XACL::content.
>> "xacl.h", line 168: Warning: content hides XACL::content.
>> "xacl.h", line 194: Warning: content hides XACL::content.
>>
>>
>> when compiling on Solaris 10.
>>
>> Also in smaller quantities,
>>
>> Compiling label.c
>> "label.c", line 490: Warning: jcr hides DCR::jcr.
>> "label.c", line 536: Warning: jcr hides DCR::jcr.
>> "label.c", line 573: Warning: jcr hides DCR::jcr.
>> 3 Warning(s) detected.
>> Compiling lock.c
>> "lock.c", line 157: Warning: file hides DEVICE::file.
>> "lock.c", line 165: Warning: file hides DEVICE::file.
>> "lock.c", line 172: Warning: file hides DEVICE::file.
>> "lock.c", line 211: Warning: file hides DEVICE::file.
>> "lock.c", line 275: Warning: file hides DEVICE::file.
>> "lock.c", line 281: Warning: file hides DEVICE::file.
>> "lock.c", line 287: Warning: file hides DEVICE::file.
>> "lock.c", line 293: Warning: file hides DEVICE::file.
>> "lock.c", line 299: Warning: file hides DEVICE::file.
>> "lock.c", line 304: Warning: file hides DEVICE::file.
>> 10 Warning(s) detected.
>
> I am seeing successful job completion on Solaris 10u9 compiled with Sun
> cc for 'i386-pc-solaris-2.10, solaris 5.10'. The above warnings appear
> to be harmless. The following patch appears to still be required for
> Solaris 10:
>
>
> --- src/findlib/fstype.c.orig 2015-09-08 07:57:34.000000000 -0400
> +++ src/findlib/fstype.c 2015-09-08 07:57:34.954835009 -0400
> @@ -278,10 +278,11 @@
>
> #elif defined(HAVE_SUN_OS)
>
> #include <sys/types.h>
> #include <sys/stat.h>
> +#include <sys/mnttab.h>
>
> bool fstype(FF_PKT *ff_pkt, char *fs, int fslen)
> {
> /* Solaris has the filesystem type name in the lstat packet */
> bstrncpy(fs, ff_pkt->statp.st_fstype, fslen);
> --- src/console/conio.c.orig 2015-08-13 09:52:24.000000000 -0400
> +++ src/console/conio.c 2015-09-08 18:30:20.464293207 -0400
> @@ -63,11 +63,10 @@
> extern "C" int tgetent(void *, const char *);
> extern "C" int tgetnum(const char *);
> extern "C" char *tgetstr (const char*, char**);
> # Note: the following on older (Solaris 10) systems
> # may need to be moved to after the #endif
> -extern "C" char *tgoto (const char *, int, int);
> #endif
> #elif defined(__sgi)
> extern "C" int tgetent(char *, char *);
> extern "C" int tgetnum(char id[2]);
> extern "C" char *tgetstr(char id[2], char **);
> @@ -76,10 +75,12 @@
> extern "C" int tgetent(void *, const char *);
> extern "C" int tgetnum(const char *);
> extern "C" char *tgetstr (const char*, char**);
> extern "C" char *tgoto (const char *, int, int);
> #endif
> +extern "C" char *tgoto (const char *, int, int);
> +
> #include "func.h"
>
>
> /* From termios library */
> #if defined(HAVE_HPUX_OS) || defined(HAVE_AIX_OS)
> --- src/cats/cats.h.orig 2015-09-08 18:35:49.663167369 -0400
> +++ src/cats/cats.h 2015-08-13 09:52:24.000000000 -0400
> @@ -64,11 +64,11 @@
>
> /* What kind of driver we have */
> typedef enum {
> SQL_DRIVER_TYPE_MYSQL = 0,
> SQL_DRIVER_TYPE_POSTGRESQL = 1,
> - SQL_DRIVER_TYPE_SQLITE3 = 2,
> + SQL_DRIVER_TYPE_SQLITE3 = 2
> } SQL_DRIVER;
>
>
> /* ==============================================================
> *
>
>
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Bacula-devel mailing list
Bacula-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-devel
