|
Hello Carsten, I am looking at the request you made (see below). First: yes, I will be happy to consider your request, but have several questions: 1. What is wrong with the current SHA1 code/license? For me the license is very much like a BSD license and I don't see a problem with it on the license stand point. 2. Are you be 100% sure that the code written by Steve Reid did not include any copyrighted material? 3. I would like to see a comparison of the speed of the current code in Bacula vs the new proposed SHA1. 4. I would like to see a comparison of the output of the two routines to ensure that they are identical. Note 1: currently SHA1 is not used much in Bacula (default), but I am considering changing the current MD5 default hash used for authentication as well as the file data hash to SHA1, so the speed of the SHA1 algorithm will become much more important. Note 2: seemingly simple changes such as this have in the past created a number of unexpected problems (e.g. with big endian architectures or compiling on "esoteric" architectures/OSes. Consequently, I would prefer some strong arguments in your responses. Best regards, Kern
On 09/16/2017 05:32 PM, Carsten
Leonhardt wrote:
Hi Kern, would you consider the following patch that replaces the SHA1 function with another one by Steve Reid that's undoubtedly free? (c.f. http://bugs.bacula.org/view.php?id=1869)The proposed replacement is used in many open source projects, as can be verified at https://codesearch.debian.net/search?q=Steve+Reid In essence, it just changes the sole occurence of "SHA1Context" to "SHA1_CTX" in src/lib/crypto.c and replaces src/lib/sha1.[ch] with those found in libsolve (https://github.com/openSUSE/libsolv/tree/master/src). I'll run tests with the patch if there's a chance that it could be adopted. Regards, Carsten |
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Bacula-devel mailing list Bacula-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bacula-devel
