Hello Carsten,

For the moment CacheRetention is not used, so there is not a problem.  Later when cacheretention is used, the type should probably be fixed to be the same across databases, but in reality, it makes no difference if it is an integer or unsigned integer unless the user is trying to specify extremely large values when he/she should use 0.

Best regards,

Kern


On 11/05/2017 08:17 PM, Carsten Leonhardt wrote:
Hi,

there are differences in the data type for used for CacheRetention, in
some cases it's "BIGINT" and sometimes "BIGINT UNSIGNED". Is that ok?

Quick check:

$ cd src/cats; grep -i CacheRetention *_tables.in
$ grep -i CacheRetention *_tables.in
make_mysql_tables.in:   CacheRetention BIGINT UNSIGNED DEFAULT 0,
make_mysql_tables.in:   CacheRetention BIGINT UNSIGNED DEFAULT 0,
update_mysql_tables.in:ALTER TABLE Media ADD COLUMN CacheRetention BIGINT 
DEFAULT 0;
update_mysql_tables.in:ALTER TABLE Pool  ADD COLUMN CacheRetention BIGINT 
DEFAULT 0;

make_postgresql_tables.in:    cacheretention    bigint   default 0,
make_postgresql_tables.in:    cacheretention    bigint     default 0,
update_postgresql_tables.in:ALTER TABLE media ADD COLUMN cacheretention BIGINT 
DEFAULT 0;
update_postgresql_tables.in:ALTER TABLE pool ADD COLUMN cacheretention BIGINT 
DEFAULT 0;

make_sqlite3_tables.in:   CacheRetention BIGINT UNSIGNED DEFAULT 0,
make_sqlite3_tables.in:   CacheRetention BIGINT UNSIGNED DEFAULT 0,
update_sqlite3_tables.in:   CacheRetention BIGINT UNSIGNED DEFAULT 0,
update_sqlite3_tables.in:ALTER TABLE Pool ADD COLUMN CacheRetention BIGINT 
DEFAULT 0;

Regards,

Carsten

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Bacula-devel mailing list
Bacula-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-devel



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Bacula-devel mailing list
Bacula-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-devel

Reply via email to