Sorry, I meant to say the change reason was "Remove unused prototype recv(len)" after a change with reason "Fix complier warning due to unused subroutine variable".
__Martin >>>>> On Mon, 17 Dec 2018 19:45:43 GMT, Martin Simmons said: > > Hi Kern, > > The change reason for dd0cd2b1016f86c34d790d2f819af5ea245ab4e3 was "Fix > complier warning due to unused subroutine variable" so maybe the fix in > 607303c975cc361802bb93db8317d8c32c8701a5 was causing other warnings about > BSOCK? Ironically, it seems that BSOCKCORE::recv(int) is never actually used > in the Community source (maybe it is used in Enterprise?). > > Yes, I'm using a newer version of clang now, so the warnings about "register" > in edit.c etc are probably new to the compiler. Removing all uses of register > seems like a safe option since it is deprecated even in C++11. > > I've created https://bugs.bacula.org/view.php?id=2443 as requested. > > __Martin > >>>>> On Mon, 17 Dec 2018 18:49:27 +0100, Kern Sibbald said: > > > > Hello Martin, > > > > Thanks for the report. > > > > That is strange. I thought the BSOCK stuff had been corrected in > > 9.2.2. Maybe some patches got lost as you note. I will check this. I > > was 99% sure I started from the latest 9.2.2, but maybe not ... > > > > The problems from the cloud driver don't surprise me much as it is new > > code and it looks relatively easy to fix. > > > > Concerning: edit.c I am a bit confused since I don't believe that file > > has been changed in a long time. Are you using a newer compiler? > > > > I will be traveling later this week and may not be able to get to things > > until late January, so would you mind just pasting > > a copy of your email into a bug report -- that will ensure that it does > > not get lost in my inbox over the holiday season. > > > > Best regards, > > Kern > > > > On 12/17/18 5:08 PM, Martin Simmons wrote: > > > Thanks, that's a long list of changes. > > > > > > Compiling it on FreeBSD 11.2 gives a few warnings for files in > > > bacula/src/lib > > > though: > > > > > > 1. Many of these: > > > > > > Compiling attr.c > > > In file included from attr.c:27: > > > In file included from ../bacula.h:169: > > > In file included from ../lib/lib.h:51: > > > ./bsock.h:73:12: warning: 'BSOCK::recv' hides overloaded virtual function > > > [-Woverloaded-virtual] > > > int32_t recv(); > > > ^ > > > ./bsockcore.h:140:20: note: hidden overloaded virtual function > > > 'BSOCKCORE::recv' declared here: different number > > > of parameters (1 vs 0) > > > virtual int32_t recv(int /*len*/); > > > ^ > > > 1 warning generated. > > > > > > Your change dd0cd2b1016f86c34d790d2f819af5ea245ab4e3 removed the fix for > > > this > > > warning that had been added in 607303c975cc361802bb93db8317d8c32c8701a5 > > > (see > > > https://www.mail-archive.com/bacula-devel@lists.sourceforge.net/msg09044.html). > > > > > > > > > 2. Several of these: > > > > > > In file included from acquire.c:26: > > > In file included from ./stored.h:89: > > > In file included from ./cloud_dev.h:35: > > > In file included from ./cloud_driver.h:28: > > > ./cloud_transfer_mgr.h:170:8: warning: class 'transfer_manager' was > > > previously declared as a struct > > > [-Wmismatched-tags] > > > friend class transfer_manager; > > > ^ > > > ./cloud_transfer_mgr.h:35:8: note: previous use is here > > > struct transfer_manager; > > > ^ > > > ./cloud_transfer_mgr.h:188:1: warning: 'transfer_manager' defined as a > > > class here but previously declared as a > > > struct [-Wmismatched-tags] > > > class transfer_manager : public SMARTALLOC > > > ^ > > > ./cloud_transfer_mgr.h:35:1: note: did you mean class here? > > > struct transfer_manager; > > > ^~~~~~ > > > class > > > 3 warnings generated. > > > > > > > > > 3. Several like this in various files: > > > > > > Compiling edit.c > > > edit.c:32:4: warning: 'register' storage class specifier is deprecated > > > and incompatible with C++17 > > > [-Wdeprecated-register] > > > register char *p = str; > > > ^~~~~~~~~ > > > > > > > > > 4. Undefined behavior warnings from va_start: > > > > > > Compiling var.c > > > var.c:2439:18: warning: passing an object that undergoes default argument > > > promotion to 'va_start' has undefined > > > behavior [-Wvarargs] > > > va_start(ap, mode); > > > ^ > > > var.c:2431:18: note: parameter of type 'var_config_t' is declared here > > > var_config_t mode, > > > ^ > > > 1 warning generated. > > > > > > Compiling output.c > > > output.c:162:22: warning: passing an object that undergoes default > > > argument promotion to 'va_start' has undefined > > > behavior [-Wvarargs] > > > va_start(arg_ptr, first); > > > ^ > > > output.c:155:43: note: parameter of type 'OutputType' is declared here > > > char *OutputWriter::get_output(OutputType first, ...) > > > ^ > > > output.c:186:22: warning: passing an object that undergoes default > > > argument promotion to 'va_start' has undefined > > > behavior [-Wvarargs] > > > va_start(arg_ptr, first); > > > ^ > > > output.c:181:58: note: parameter of type 'OutputType' is declared here > > > char *OutputWriter::get_output(POOLMEM **out, OutputType first, ...) > > > ^ > > > 2 warnings generated. > > > > > > > > > __Martin > > > > > > > > > > > > > > >>>>>> On Sun, 16 Dec 2018 19:06:00 +0100, Kern Sibbald said: > > >> Hello, > > >> > > >> We are pleased to announce the release of Bacula version 9.4.0. > > >> > > >> This is a major release (currently a Beta release) comprised of more > > >> than 13,000 lines of differences since version 9.2.2. It has updates to > > >> Baculum and small number of bug fixes and back ports from Bacula Systems > > >> Enterprise since version 9.2.2. > > >> > > >> The main new feature is the addition support for using Amazon S3 (and > > >> other *identical* S3 providers). Note: Azur, Oracle S3,and Goggle S3 > > >> are not compatible with Amazon S3. > > >> > > >> Please note that there is a new Bacula Cloud white paper that goes into > > >> detail on how to use the new Bacula Cloud S3 driver. > > >> > > >> Also, please do not forget to read the New Features for 9.4.x of the > > >> manual for more details on what the new features are and how they work. > > >> > > >> Before putting the S3 driver into production, please test carefully both > > >> backups and especially restores. > > >> > > >> 16Dec18 > > >> – Add copyright and correct name on stop-restart-test > > >> – Fix #4449 about an incorrect pool selected with the restart command > > >> – Fix #4386 About incorrect permission on directories after a restore > > >> with > > >> replace=ifnewer > > >> – Fix bug #4379 certain fields of Media record not reset after Truncate > > >> command > > >> – Revert “Update bdirjson.c” > > >> – Improve volume truncation error messages > > >> – Free ids buffer > > >> – Update PO files > > >> – Initial version and date update > > >> – Initial cut of ChangeLog and ReleaseNotes > > >> – Add use_dcr_only in cloud_dev.c so that manual truncate works > > >> – More Enterprise backports > > >> – More Enterprise backports + changes to the backporting > > >> – Minor backport from Enterprise + my own changes > > >> – Update bdirjson.c > > >> – Add pseudo WORM support for vtape > > >> – worm: Fix multiple display of the WORM Recycle message > > >> – Add first cut cloud drivers > > >> – Use bfopen in place of fopen > > >> – Fix #3574 Add “clients” option to the “help list” output > > >> – Add makedir() in fd_common.h > > >> – Add bfile is_plugin_data() API > > >> – Fix issue between FO_PORTABLE and FO_PORTABLE_DATA > > >> to api > > >> – Fix NOATTR detection > > >> – Implement worm cassette support > > >> – Make detection of duplicate M_SECURITY messages work > > >> – Remove unused prototype recv(len) > > >> – Add new security monitoring test > > >> – Implement new message numbers in stored/block.c > > >> – Fix incorrectly indicating: malformed message > > >> – Fix bugs #2335 and #2349 Volume messages printed many times > > >> – Add new test for bug printing many multiple Max Volume jobs= info > > >> – Add worning message about failure to update volume info > > >> – Improve error messages when JobMedia errors > > >> – Fix complier warning due to unused subroutine variable > > >> – Fix bug #2334 seg fault when releasing globals > > >> – Security: sleep(5) on error + aggregating identical messages > > >> – Update sellist unittests. > > >> – Update unittests for lockmgr.c and fix memory leak. > > >> – Update unittests fir ConfigFile/ini.c. > > >> – Update ‘rm -f’ for libtool $(RMF). > > >> – Correct libs/Makefile.in separator. > > >> – Update htable unittests. > > >> – Update sha1 unittests. [ReleaseNotes] IQ > > >> – Add fnmatch unittests. > > >> – Update unit tests and add regression tests for it. > > >> – Fix escaping special characters in bvfs restore for sqlite catalog > > >> – Add new manual test > > >> – baculum: Do not store any main oauth2 client nor main http basic user > > >> in api > > >> config > > >> – Fix tls_bsock_shutdown() compilation when no TLS available. > > >> – Fix bsock compilation warning. > > >> – Fix bsock compilation problem in *BSD. > > >> – Permit negative FileIndex values in the catalog > > >> – Fix format string is not a string literal (potentially insecure). > > >> > > >> – baculum: Update Japanese translation files > > >> – baculum: Fix availability web config wizard when there is problem with > > >> access > > >> – baculum: Add new size directive control > > >> – baculum: Fix basic auth user setting in API install wizard > > >> – baculum: Fix undefined index error on web config wizard page > > >> – baculum: Fix #2418 creating or updating new resource > > >> – baculum: Fix size unit formatters in restore browser reported by > > >> Wanderlei Huttel > > >> – baculum: Fix logging output if it is not possible to decode to json > > >> – baculum: Improve error handling in web part > > >> – baculum: Fix formatted size and time values on the volume details page > > >> – baculum: Fix saving logs when an error occurs > > >> – baculum: API panel and wizard improvements > > >> – baculum: Add name field to api client parameters > > >> > > >> Bugs fixed/closed since last release: > > >> 2334 2335 2418 3574 4379 4386 4449 > > >> > > >> ==== > > >> > > >> This new release is well tested, but if using any of the new features > > >> such as the S3 Cloud driver, please be careful to test it. > > >> > > >> I will be on "vacation" during the holiday period, but will be back in > > >> late January. > > >> > > >> Thanks for using Bacula. Enjoy Bacula as well as the holiday season ... > > >> > > >> Best regards, > > >> > > >> Kern > > >> > > >> > > >> > > >> > > >> _______________________________________________ > > >> Bacula-devel mailing list > > >> Bacula-devel@lists.sourceforge.net > > >> https://lists.sourceforge.net/lists/listinfo/bacula-devel > > >> > > > > > _______________________________________________ Bacula-devel mailing list Bacula-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bacula-devel
