Hello Sven,
After Christmas I will take a look at your patches. Your way of doing
it sounds
more correct to me than what the Bacula guys did -- for me fixing warnings
is better than masking them.
Best regards,
Kern
On 12/20/18 5:18 PM, Sven Hartge wrote:
On 20.12.18 17:07, Kern Sibbald wrote:
Many thanks for the heads up ...
In fact, the main difference is this here:
--- libs3-2.0+20161214git06a4683/GNUmakefile 2016-12-14
19:13:34.000000000 +0100
+++ libs3-20181010/GNUmakefile 2018-10-11 09:29:33.000000000 +0200
@@ -136,7 +136,7 @@
endif
endif
-CFLAGS += -Wall -Werror -Wshadow -Wextra -Iinc \
+CFLAGS += -Wall -Werror -Wshadow -Wextra -Wno-format-truncation -Iinc \
$(CURL_CFLAGS) $(LIBXML2_CFLAGS) \
-DLIBS3_VER_MAJOR=\"$(LIBS3_VER_MAJOR)\" \
-DLIBS3_VER_MINOR=\"$(LIBS3_VER_MINOR)\" \
This change gets rid of the errors GCC throws by disabling the warning,
while the patch I cooked up tries do address them by changing the way
strncat is used.
Grüße,
Sven.
_______________________________________________
Bacula-devel mailing list
Bacula-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-devel
