Thanks to Martin for the fix and to Phil for confirming it.  I have patched Bacula and pushed it to the repo.

For the moment, EndBlock is 32 bits, maybe someone can explain why it should overflow -- that seems like a *very* big volume, but maybe it is time to make it 64 bits, but that requires a DB change. The next release, probably in the Spring, will require a DB upgrade so if a 64 bit EndBlock
is really needed it will be a good time to do it.

Best regards,
Kern

On 12/31/18 7:24 PM, Martin Simmons wrote:
On Mon, 31 Dec 2018 13:19:35 -0500, Phil Stracchino said:
On 12/31/18 8:56 AM, Martin Simmons wrote:
It looks like EndBlock=%d should be EndBlock=%u in
BDB::bdb_update_media_record (bacula/src/cats/sql_update.c line 378).
OK, after propagating the patch to *ALL* relevant machines, it looks
like that did it.
Great.

BTW, just changing EndBlock to uint64_t  will not work because both %u and %lu
expect 32 bits in Bacula's formatting functions (unlike in printf).

__Martin


_______________________________________________
Bacula-devel mailing list
Bacula-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-devel




_______________________________________________
Bacula-devel mailing list
Bacula-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-devel

Reply via email to